[Live-devel] fNumFramesUsedSoFar and MutiFramedRTPSink

[David BERTRAND]

I noticed a problem with variable fNumFramesUsedSoFar when MultiFramedRTPSink::ourHandleClosure() is called. In this case, sendPacketIfNecessary() is called in case we have a partially built packet to send. But variable fNumFramesUsedSoFar is only reset in buildAndSendPacket function which in this case won't be done. IMO, this reset should (also?) be done after really sending the packet, i.e at the end of function sendPacketifNecessary, for example just after incrementing SEQN. Otherwise, some "empty" packet may be sent and SEQN will wrongly be incremented.
Ross, do you agree with my analysis ?
Thanks,
David 
> ----- Original Message -----
> From: "Ross Finlayson" <finlayson at live555.com>
> To: "LIVE555 Streaming Media - development & use" <live-devel at ns.live555.com>
> Subject: Re: [Live-devel] RTCP Receiver Report
> Date: Tue, 28 Mar 2006 15:11:23 -0800
> 
> 
> 
> > Are there any suggestions on how I can read the RTCP Receiver's 
> > Report packet?
> 
> Look at the "RTPTransmissionStats" class (defined in
> "liveMedia/include/RTPSink.hh").  This is updated automatically (by
> the server) each time a RTCP Reception Report (RR) packet arrives.
> 
> You'll have to look at the code to figure out how to use this, but it
> is very similar to the "RTPReceptionStats" class which is used at the
> receiver end (and updated each time a RTCP Sender Report (SR) packet
> arrives).  See "testProgs/playCommon.cpp" for an example of how
> "RTPReceptionStats" is used.
> 
> 
> 	Ross Finlayson
> 	Live Networks, Inc. (LIVE555.COM)
> 	<http://www.live555.com/>
> 
> _______________________________________________
> live-devel mailing list
> live-devel at lists.live555.com
> http://lists.live555.com/mailman/listinfo/live-devel

>


-- 
_______________________________________________
Surf the Web in a faster, safer and easier way:
Download Opera 8 at http://www.opera.com

Powered by Outblaze