[Live-devel] Race condition bug fix

[Geoff Cleary]

The following fix prevents a bug when two requests are processed in close
proximity. Should pass the parser the pointer to the new request not the
address of the buffer.

 

*** lib/live/liveMedia/RTSPServer.cpp   2007-06-15 14:44:10.811882441 -0400

--- ./lib/live/liveMedia/RTSPServer.cpp   2007-09-12 15:01:55.216824905
-0400

***************

*** 350,356 ****

    char urlPreSuffix[RTSP_PARAM_STRING_MAX];

    char urlSuffix[RTSP_PARAM_STRING_MAX];

    char cseq[RTSP_PARAM_STRING_MAX];

!   if (!parseRTSPRequestString((char*)fRequestBuffer,
fRequestBytesAlreadySeen,

                              cmdName, sizeof cmdName,

                              urlPreSuffix, sizeof urlPreSuffix,

                              urlSuffix, sizeof urlSuffix,

--- 350,356 ----

    char urlPreSuffix[RTSP_PARAM_STRING_MAX];

    char urlSuffix[RTSP_PARAM_STRING_MAX];

    char cseq[RTSP_PARAM_STRING_MAX];

!   if (!parseRTSPRequestString((char*)ptr, bytesRead,

                              cmdName, sizeof cmdName,

                              urlPreSuffix, sizeof urlPreSuffix,

                              urlSuffix, sizeof urlSuffix,

 

=======================

Geoff Cleary, Principal Software Engineer

SightLogix, Inc.

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.live555.com/pipermail/live-devel/attachments/20070912/66deea3e/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 1836 bytes
Desc: not available
Url : http://lists.live555.com/pipermail/live-devel/attachments/20070912/66deea3e/attachment.gif