[Live-devel] two questions about liveMedia source code

[Changjin Liu]

Hello, Ross

 

I'm reading liveMedia source code(version 2008.4.3), and have two questions
about it

 

(1)     in RTSPClient::setupMediaSubsession    (RTSPClient.cpp, line 956):

subsession.connectionEndpointName() = serverAddressStr;

where the serverAddressStr comes from the transport section of SDP response
of Server.

 

But in the same function(line 983),

"subsession.setDestinations(fServerAddress)"  set the destination address of
the client subsession to fServerAddress

 

I searched fServerAddress and found that it is set in
RTSPClient::openConnectionFromURL( line 1792). fServerAddress comes

from the RTSP URL.

 

So why not set the mediaSubSession destination address to the address of
SETUP response?

 

If the RTSP URL is more appropriate, then is line 956 redundant?

 

(2)     In rtcp_from_spec.c, line 286, the OnReceive function,

 

if (TypeOfEvent(e) == EVENT_BYE) {

               *members += 1;

}

 

I read RFC3550 A.7, it has the same code above.

 

Why not should it be:

 

if (TypeOfEvent(e) == EVENT_BYE) {

               *members -= 1;

}

 

 

Thanks.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.live555.com/pipermail/live-devel/attachments/20080408/92c628ab/attachment.html