[Live-devel] [patch] minor mem leaks in RTSP client and server (and qtfilesink)

[Erik Hovland]

On Fri, Jul 04, 2008 at 10:52:56PM -0700, Erik Hovland wrote:
> On Fri, Jul 04, 2008 at 09:07:57PM -0700, Ross Finlayson wrote:
> >> These patches only fix corner cases of memory leaks. But they should be
> >> fairly non-invasive. So please consider them.
> >
> > Thanks.  I have now released a new version (2008.07.05) of the software 
> > that includes all of your recent suggestions.  If possible, please rerun 
> > your testing tools on this new version.
> 
> Will do.

Did do. For some reason the RTSPServer memory leaks fix did not quite
get in.

Here is the same patch against 2008.07.05.

E

---

 liveMedia/RTSPServer.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/liveMedia/RTSPServer.cpp b/liveMedia/RTSPServer.cpp
index 24b5c34..65b8830 100644
--- a/liveMedia/RTSPServer.cpp
+++ b/liveMedia/RTSPServer.cpp
@@ -809,8 +809,8 @@ void RTSPServer::RTSPClientSession
       break;
     }
     }
-    delete[] destAddrStr; delete[] sourceAddrStr; delete[] streamingModeString;
   }
+  delete[] destAddrStr; delete[] sourceAddrStr; delete[] streamingModeString;
 }
 
 void RTSPServer::RTSPClientSession
-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request