[Live-devel] [Patches] Fedora package maintainer

[Ross Finlayson]

Thanks, but I don't think I will be applying these patches, at least 
not right now.

First, I don't plan on releasing any 'config.' files that do dynamic 
linking, because these days - for most environments, with RAM being 
so plentiful - dynamic linking often causes more trouble than it's 
worth.  (If people want to write their own 'config.' files that do 
dynamic linking, then that's fine; it's just that I don't plan on 
distributing any such 'config.' files.)

Also:

>diff -uNr live/groupsock/GroupsockHelper.cpp 
>live-patches/groupsock/GroupsockHelper.cpp
>--- live/groupsock/GroupsockHelper.cpp	2009-03-22 23:26:16.000000000 +0100
>+++ live-patches/groupsock/GroupsockHelper.cpp	2009-03-24 
>14:10:56.000000000 +0100
>@@ -474,12 +474,14 @@
>  //    let us know, by sending email to the "live-devel" mailing list.
>  //    (See <http://lists.live555.com/mailman/listinfo/live-devel/> 
>to subscribe to that mailing list.)
>  // END NOTE TO CYGWIN DEVELOPERS
>+#if !(defined(__FreeBSD_kernel__) && defined(__GLIBC__))
>  struct ip_mreq_source {
>    struct  in_addr imr_multiaddr;  /* IP multicast address of group */
>    struct  in_addr imr_sourceaddr; /* IP address of source */
>    struct  in_addr imr_interface;  /* local IP address of interface */
>  };
>  #endif
>+#endif

I don't understand this.  Does Fedora have the same bug as Cygwin - 
i.e., does it define IP_ADD_SOURCE_MEMBERSHIP, but not define 
ip_mreq_source??  If that's really the case, then you should fix 
Fedora.


>diff -uNr live/liveMedia/H263plusVideoRTPSink.cpp 
>live-patches/liveMedia/H263plusVideoRTPSink.cpp
>--- live/liveMedia/H263plusVideoRTPSink.cpp	2009-03-22 
>23:26:16.000000000 +0100
>+++ live-patches/liveMedia/H263plusVideoRTPSink.cpp	2009-03-24 
>14:10:56.000000000 +0100
>@@ -64,7 +64,7 @@
>      }
>      if (frameStart[0] != 0 || frameStart[1] != 0) {
>        envir() << "H263plusVideoRTPSink::doSpecialFrameHandling(): 
>unexpected non-zero first two bytes: "
>-	      << (void*)(frameStart[0]) << "," << 
>(void*)(frameStart[1]) << "\n";
>+	      << (frameStart[0]) << "," << (frameStart[1]) << "\n";

I needed these (void*) casts to ensure that 1-byte values get printed 
properly, at least on my FreeBSD system.  If they don't cause any 
problems in Fedora, then I'll just leave them as is.

-- 

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/