[Live-devel] [PATCH] Enable logging levels, part1

[Ross Finlayson]

>  > Having said all this, I do admit, though, that the
>>  diagnostic/debugging output in the provided code is a bit
>>  inconsistent right now
>
>I'd rather say insufficient.
>For example in RTSPClient.cpp there are
>if (fVerbosityLevel >= 1) envir() << something;
>all over the code.
>But IMHO it looks not enough fine grained. Some of such "messages" 
>are at debug
>level, some are at info level and some could even be on warning level.
>
>Even more important is, that my code (like MyUsageEnvironment)  does not
>receive "verbosity level" in my operator<< for particular messages . So I'm
>not able to fiter them (or redirect to different destinations - console, file,
>syslog, ...).

("verbosityLevel", right now, is a parameter just to 
"RTSPClient::createNew()".  At some point in the future, this will 
likely be generalized.  But not right now.)

As I noted in my earlier message, your "[Basic]UsageEnvironment" 
subclass can redefine "operator<<" to do whatever it wants with all 
of the output from the supplied library code (e.g., give it some 
'default' logging level) - and, if you wish, you can do other things 
with output from your own application code.


>I think proper logging is vital part of any non-trivial code. I'm willing to
>cooperate with you to introduce it in live555 library.

No.  Logging is necessarily application specific.  As I noted in my 
earlier message, you can do it however you want in your 
"[Basic]UsageEnvironment" subclass.  But I won't be adding any 
specific 'logging' functionality to the supplied "LIVE555 Streaming 
Media" library code.


>Well, but proper logging is really important for me right now.

And I've told you how you can do it.  If you don't want to write your 
application-specific code in the proper way - by defining your own 
subclass of "[Basic]UsageEnvironment", then you're on you own.  Sorry.


>Are you willing to discuss modifications?

As I noted in my earlier message: At some point I will likely be 
cleaning up the debugging/diagnostic output that's done in the 
library code.  But not right now.  But you can do whatever you want 
with the output from your own application code, and that's all that 
you should be concerning yourself with right now.


>Are you willing to incorporate patches?

Yes - if they fit with the overall architecture of the code.  Yours 
did not, for the reasons I explained in my earlier message.
-- 

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/