[Live-devel] [PATCH] Enable logging levels, part1

[Ross Finlayson]

>  > >I think proper logging is vital part of any non-trivial code. I'm willing
>>  >to cooperate with you to introduce it in live555 library.
>>
>>  No.  Logging is necessarily application specific.
>
>Then why do you ever have it in the library?

OK, this is just a difference in word interpretation.  I consider the 
LIVE555 library code to be doing "output".  I consider the word 
"logging" to mean one particular implementation of output - whereby 
the data is written serially to some non-volatile medium.  And that, 
of course, is application specific.


>I really really need to filter by importance.Using RTSPClient.cpp as example I
>have no way to decide if that "message" is debug one like
>envir() << "Opening connection to " ...
>or just something even less important like
>envir() << "...local connection opened\n"
>or somethig informative (more than debug) like
>envir() << "Sending request: " << cmd << "\n"

Well, in my mind, these three messages are all equally 'important' 
(or, at the very least, the 2nd message - contrary to what you said - 
is very important, because - if the client and server are on separate 
nodes - there's no guarantee in general that the connection opening 
will succeed).

In any case, I just don't see what you could be doing that could make 
you "really really need" to treat these three messages differently 
(and that you couldn't do instead using string pattern matching in 
your application code).  But in any case, this is not a priority for 
me.  Sorry.


>  > >Are you willing to incorporate patches?
>>
>>  Yes - if they fit with the overall architecture of the code.
>
>All right, I will try again with something completely different (not logging).

The patches that I'm most likely to accept are either bug fixes, or 
modifications that make it easier for people to develop their own 
custom application code without requiring them to make additional, 
application-specific modifications inside the supplied library code.
-- 

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/