[Live-devel] Callback not being called in case of unknown response

[Sébastien Escudier]

On Wed, 2010-10-06 at 02:38 -0700, Ross Finlayson wrote:
> >foundRequest is NULL because the response does not include a CSeq value.
> 
> Can you fix the server? :-)

I'll try :)

> So, if you change line 1448 from
>            } else if (request->cseq() == cseq) {
> to
>            } else if (request->cseq() == cseq || cseq == 0) {
> then things should work in this case.

It can't work like that because we don't reach this code because of :
checkForHeader(lineStart, "CSeq:", 5, headerParamsStr)

But I have another solution. line 1482, replace :

if (foundRequest == NULL && responseIsHTTP) {
// Hack: HTTP responses don't have a "CSeq:" header, so if we got a HTTP response, assume it's for our most recent request:

by

if (foundRequest == NULL) {
 // Hack: The response don't have a "CSeq:" header, assume it's for our most recent request:

Would you accept this change for the next version ?