[Live-devel] A bug when interpreting RTP extend packet.

[Ross Finlayson]

> line 268:  unsigned remExtSize = 4*(extHdr&0xFFFF);
> Pls pay attension to line 268. Here you calculated RTP packet extension size with extHdr length directly,
> but it should be network bytes order, need to be transfered to host byte order firstly.
>  
> E.g:   unsigned remExtSize = 4 * ntohs(extHdr & 0xFFFF);
>  
> How do you think ?

No, because we already converted the data to host byte order when we assigned the "extHdr" field, in the previous line (line 267):
	unsigned extHdr = ntohl(*(u_int32_t*)(bPacket->data())); ADVANCE(4);


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20120504/385d0c4b/attachment.html>