[Live-devel] RTSPServer Access Control Change Request

[Chris Richardson (WTI)]

Hi Ross,

 

The specialClientAccessCheck function can be used to test the IP
address/port against the stream suffix, but not the user name.  If a
subclass needs to check the user name, it will have to parse the request
itself, which usually leads to error prone code duplication.  Then, in the
event that the subclass decides to allow the request, the RTSPServer must
parse the request once again and then potentially deny the user access
anyways.  It just doesn't seem that useful to me, with the exception of
providing IP address/port blacklisting.

 

I briefly considered changing the signature of specialClientAccessCheck to
include an optional parameter for the user name, but that would not only
change the semantics of the operation (it would have to be called after
parsing the request), it would also obviously break existing subclasses
silently.

 

I will try to think of another way to perform user-specific access control
without disturbing the code too much.  Also, if anybody else has ideas, I am
all ears and happy to implement whatever is decided on.  Otherwise I will
just carry this patch.

 

Thanks,

 

Chris Richardson

WTI

 

From: live-devel-bounces at ns.live555.com
[mailto:live-devel-bounces at ns.live555.com] On Behalf Of Ross Finlayson
Sent: Friday, January 04, 2013 12:11 PM
To: LIVE555 Streaming Media - development & use
Subject: Re: [Live-devel] RTSPServer Access Control Change Request

 

I'm confused.  There's already a "specialClientAccessCheck()" virtual
function (defined in "liveMedia/include/RTSPServer.hh") that I added in
April 2007 in order to allow special-purpose access control - beyond the
usual digest authentication mechanism.  Is that not sufficient for your
purpose?  I don't plan on adding yet another virtual function like this.

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/ 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20130104/2f4b8d67/attachment.html>