[Live-devel] ProxyServerMediaSession not working correctly for more than one client per stream

[Subhankar Saha]

Hi Ross,

                This is assuming, of course, that you haven't modified the code at all.  If you have modified the code, then all bets are off...

No, we have not made any modification to the code at all, except changing "win32config" for TOOLS32 (to put correct VC path) and LINK_OPTS_0 (use msvcrt.lib instead of msvcirt.lib).

Also, like I stated before, the issue can be reproduced using the included "proxyServer" application.

We did some investigation with few older versions of live555 source base we have in store. It seems, the issue was not there in version 2013.04.21. It seemed to have first appeared in 2013.04.23. I diff-ed these two versions of source codes. Most of the changes did not appear to be related to the issue we are seeing, but one change in OnDemandServerMediaSubsession.cpp does look like it is contributing to the problem:

In version 2013.04.23, following lines are added in function "StreamState::endPlaying":

  if (fRTCPInstance != NULL) {
    // Hack: Explicitly send a RTCP "BYE" packet now, because the code below will prevent that from happening later,
    // when "fRTCPInstance" gets deleted:
    fRTCPInstance->sendBYE();
  }

If we comment out the above lines then we find things working again as expected - that is, closing one client no longer closes the other client(s).

Now, we know you have added the above code because of a problem we had raised earlier - it was to fix live555 not sending BYE when server sessions are closed on the server side. But we think this change is now contributing to the current problem!

Once again, no change was done to code anywhere. And the problem can be seen just by running 'proxyServer' application. We used VLC as clients.

Regards,
Subhankar.


________________________________

http://www.mindtree.com/email/disclaimer.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20130530/6b0ebf4a/attachment.html>