[Live-devel] problem processing RTSP TEARDOWN

[Ross Finlayson]

> The problem report by valgrind occurs processing TEARDOWN because :
> -       RTSPServer:1016   clientSession->handleCmd_withinSession(this, cmdName, urlPreSuffix, urlSuffix, (char const*)fRequestBuffer);
> => delete the RTSPClientSession the is pointed by clientSession.
> -       RTSPServer:1098    if (clientSession != NULL && clientSession->fStreamAfterSETUP && strcmp(cmdName, "SETUP") == 0) {
> ð  The deleted clientSession is not NULL, point on a unallocated memory and clientSession->fStreamAfterSETUP is evaluated.

Yes, you're right; I misinterpreted the valgrind report.

Changing line 1098 to
	if (strcmp(cmdName, "SETUP") == 0 && clientSession != NULL && clientSession->fStreamAfterSETUP) {
or just
	if (strcmp(cmdName, "SETUP") == 0 && clientSession->fStreamAfterSETUP) {
will avoid the problem.

The next release of the software will include this fix (actually, a better fix that eliminates the call to "strcmp()").


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20140117/5e888fea/attachment.html>