[Live-devel] RTSP authentication with special characters

[Deanna Earley]

Thank you Ross.

There does seem to be a termination issue in your version though.
I don't see the null terminators being added, possibly the cause for this:

Resending...
Sending request: DESCRIBE rtsp://abcd:ab%40cd@10.1.20.1/axis-media/media.amp RTSP/1.0
CSeq: 4
Authorization: Basic YWJjZGw6YWJAY2Q=
User-Agent: openRTSP (LIVE555 Streaming Media v2015.03.06)
Accept: application/sdp

The auth details end up as:
abcdl:ab at cd

This also breaks normal username and passwords without special characters:

Resending...
Sending request: DESCRIBE rtsp://abcd:abcd@10.1.20.1/axis-media/media.amp RTSP/1.0
CSeq: 4
Authorization: Basic YWJjZGw6YWJjZHI=
User-Agent: openRTSP (LIVE555 Streaming Media v2015.03.06)
Accept: application/sdp

Adding this to the end of the function seems to fix it:
  *dest = '\0';

(Patch attached)

--
Deanna Earley | Lead developer | icatchercctv

w: www.icode.co.uk/icatcher<http://www.icode.co.uk/icatcher> | t: 01329 835335 | f: 01329 835338
Registered Office : 71 The Hundred, Romsey, SO51 8BZ. Company Number : 03428325

From: live-devel [mailto:live-devel-bounces at ns.live555.com] On Behalf Of Ross Finlayson
Sent: 06 March 2015 02:45
To: LIVE555 Streaming Media - development & use
Subject: Re: [Live-devel] RTSP authentication with special characters

Thanks for the note.  I've now installed a new version (2015.03.06) of the code that fixes this.

(Please check the code, however, because it's a bit different from the patch that you proposed.)

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20150306/89b73b0e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: auth details terminator.patch
Type: application/octet-stream
Size: 323 bytes
Desc: auth details terminator.patch
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20150306/89b73b0e/attachment.obj>