[Live-devel] Buffer size in MPEG2TransportStreamFromESSource

[Gilles Chanteperdrix]

On Wed, Jun 22, 2016 at 07:23:33PM -0700, Ross Finlayson wrote:
> > Instead, in the next release of the software, I’ll change “MAX_INPUT_ES_FRAME_SIZE” from a compile-time constant to a run-time variable that can be changed before the “MPEG2TransportStreamFromESSource” object is created (similar to  what we currently do with "OutPacketBuffer::maxSize”).
> 
> FYI, I’ve just installed a new version (2016.06.23) of the code that changes “MAX_INPUT_ES_FRAME_SIZE” to a static member variable "MPEG2TransportStreamFromESSource::maxInputESFrameSize” that you can, if desired, change at run time.

Hi,

Thank you very much, it works fine. I just have a remaining minor
patch: when compiling programs using live555 headers with all gcc
warnings, I get a warning in MediaTranscodingTable.hh about unused
arguments in the weWillTranscode() method. The following patch
silences these warnings:

--- live/liveMedia/include/MediaTranscodingTable.hh~	2016-06-23 04:17:01.000000000 +0200
+++ live/liveMedia/include/MediaTranscodingTable.hh	2016-06-23 08:57:39.502026909 +0200
@@ -46,7 +46,7 @@
     return NULL;
   }
 
-  virtual Boolean weWillTranscode(char const* mediumName, char const* codecName) {
+  virtual Boolean weWillTranscode(char const* /* mediumName */, char const* /* codecName */) {
     // Default implementation: Return False.
     // You would reimplement this in a subclass - returning True for each
     // <mediumName>/<codecName> for which you'll do transcoding.

Regards.

-- 
					    Gilles.
https://click-hack.org