<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite"><div>1. I have seen possible ServerMediaSession object leak in<br>RTSPServer::RTSPClientSession::handleCmd_SETUP method.<br>This method changes client session object member variable<br>fOurServerMediaSession (pointer to ServerMediaSession) and calls<br>fOurServerMediaSession->incrementReferenceCount() if this<br>ServerMediaSession is really changed. But this method does not call<br>decrementReferenceCount() on previously stored ServerMediaSession (if<br>any). So if an RTSP client will send two SETUP commands referring<br>different streams then ServerMediaSession object of stream of first<br>SETUP command will have excess reference counter increment that will<br>prevent this ServerMediaSession object from being deleted. Maybe there<br>are no such RTSP client but I think any protection against harmful<br>behaviour of other software is welcome.<br></div></blockquote><div><br></div>Yes, there exist unusual situations in which the reference count might get too high, but fixing this is not a high priority, because in the most common situations, the reference count will get set correctly. (Also, it is relatively unusual for "removeServerMediaSession()" to be called.)</div><div><br><div><br></div><blockquote type="cite"><div>2. Also I have seen possible ServerMediaSession object relations bug<br>in RTSPServer::addServerMediaSession/RTSPServer::removeServerMediaSession<br>methods.<br>Method addServerMediaSession adds a ServerMediaSession object to<br>hashmap fServerMediaSessions and call removeServerMediaSession on<br>ServerMediaSession object previously set in the hashmap (if both<br>objects have same stream name). Method removeServerMediaSession<br>removes from the hashmap new ServerMediaSession object just added by<br>addServerMediaSession.</div></blockquote><div><br></div>Yes, this is a bug. It will get fixed in a future release. (Perhaps then I'll address the first issue also :-) Thanks for reporting this.</div><br><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Ross Finlayson<br>Live Networks, Inc.<br><a href="http://www.live555.com/">http://www.live555.com/</a></span></span>
</div>
<br></body></html>