<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 23, 2012, at 12:03 AM, Benjamin Drung <<a href="mailto:bdrung@debian.org">bdrung@debian.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson:<br><blockquote type="cite">2/ The second 'patch' seems wrong to me. I don't understand why any<br>system would define "struct ip_mreq_source", but not also define<br>"IP_ADD_SOURCE_MEMBERSHIP" (a constant that makes that structure<br>useful). I recommend removing the patch. If anyone feels that it is,<br>in fact, necessary, then they can post a message to this mailing list<br>(as they should have done in the first place!) explaining why they<br>think it's needed.<br></blockquote><br>This patch is needed for Debian GNU/Hurd. Otherwise it will fail with<br><br>c++ -c -Iinclude -I../UsageEnvironment/include -I. -O2<br>-DSOCKLEN_T=socklen_t -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -Wall<br>-DBSD=1 -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector<br>--param=ssp-buffer-size=4 -Wformat -Werror=format-security<br>GroupsockHelper.cpp<br>GroupsockHelper.cpp:447:8: error: redefinition of ‘struct<br>ip_mreq_source’<br></blockquote><div><br></div></div>The issue is not the fact that Debian GNU/Hurd defines "struct ip_mreq_source". That's perfectly understandable; lots of systems do that. The problem is that this piece of code (where we give our own definition of "struct ip_mreq_source") is being reached only because the constant "IP_ADD_SOURCE_MEMBERSHIP" is *not* defined. This is a mistake. "IP_ADD_SOURCE_MEMBERSHIP" *has to be* defined somewhere, otherwise "struct ip_mreq_source" has no purpose.<div><br></div><div>So the real solution here - rather than this bogus patch - is to find out where (in this system) IP_ADD_SOURCE_MEMBERSHIP is defined, and to add a patch, if necessary, that makes sure that the appropriate header file is #include'd.</div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Ross Finlayson<br>Live Networks, Inc.<br><a href="http://www.live555.com/">http://www.live555.com/</a></span></span>
</div>
<br></body></html>