<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><blockquote type="cite"><blockquote type="cite">1/ The first 'patch' was apparently intended to remove some compiler<br>warnings. It's harmless, but I recommend not applying it, because the<br>code that generates these compiler warnings might end up changing<br>sometime (which will break the patch).<br></blockquote><br>Why do you cast integers/bytes into void pointers? Unless there is a<br>reason, I think the patch should be applied?<br></blockquote><div><br></div>Perhaps, but I'll probably just change the code to eliminate the compiler warnings.</div><div><br></div><div><br><blockquote type="cite"><blockquote type="cite">2/ The second 'patch' seems wrong to me. I don't understand why any<br>system would define "struct ip_mreq_source", but not also define<br>"IP_ADD_SOURCE_MEMBERSHIP" (a constant that makes that structure<br>useful). I recommend removing the patch. If anyone feels that it is,<br>in fact, necessary, then they can post a message to this mailing list<br>(as they should have done in the first place!) explaining why they<br>think it's needed.<br></blockquote><br>I found a reason in the logs: "ip_mreq_source is defined in all glibc<br>not just on kfreebsd. Fix hurd FTBFS" I'll check if this patch is still<br>needed.<br></blockquote><div><br></div>See my next message...</div><div><br></div><div><br><blockquote type="cite"><blockquote type="cite">3/ The third 'patch' is definitely wrong, and should be removed. The<br>whole point of deprecating the old, synchronous "RTSPClient" interface<br>is that any code that happens to depend upon the old interface needs<br>to explicitly be updated - by<br>"#define"ing RTSPCLIENT_SYNCHRONOUS_INTERFACE - so that it can<br>continue using it. But anyway, no code that depends upon the old<br>interface is present anywhere in the LIVE555 distribution, or (I<br>presume) anywhere else in the Debian distribution either.<br></blockquote><br>I see a problem here: We build a static/shared library without the<br>deprecated old, synchronous RTSPClient interface. If a user defines<br>RTSPCLIENT_SYNCHRONOUS_INTERFACE, he will get the old header functions,<br>but linking with the static/shared library will fail.<br></blockquote><div><br></div>There's no problem here. In lots of places in the code, there are pieces of code that are #ifdef'd out by default. (E.g., these often add extra diagnostic output to help with debugging.) It's always been understood that if a developer wants to enable these pieces of code, then they need to build the library themselves - with appropriate compile-time flags - rather than rely upon a pre-built library. This is no different. So the third patch should be removed.</div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Ross Finlayson<br>Live Networks, Inc.<br><a href="http://www.live555.com/">http://www.live555.com/</a></span></span>
</div>
<br></body></html>