<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:851408136;
mso-list-type:hybrid;
mso-list-template-ids:177775776 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Hi Ross,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>In testing the most recent version (2013.06.30), I noticed a couple memory leaks. I know your stance on memory leaks, but these two occur during normal play/stop operation (not just at shutdown), and so they will have noticeable effect on long-running devices.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>In the SocketDescriptor destructor, the HashTable::Iterator* “iter” is never deleted.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>In SocketDescriptor::deregisterRTPInterface, the fDeleteMyselfNext member is set to “true”, but (for me at least), the tcpReadHandler function is never called again, and so the SocketDescriptor deletion never happens. I believe this was changed from “delete this;” in version 2013.04.29 or 2013.04.30 to avoid crashing if the tcpReadHandler is about to execute just after the socket descriptor is deleted.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>A fix that works here and does not result in a memory leak is to change the fDeleteMyselfNext back to “delete this;”, but also change RTPInterface::stopNetworkReading and RTPInterface::removeStreamSocket to set fReadHandlerProc to NULL before calling deregisterSocket. This way the read handler on the about-to-be-deleted RTPInterface is not called in case tcpReadHandler is about to execute.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I have attached a patch that fixes both issues for me, but I am definitely not an expert on the inner-workings of RTPInterface. If anybody who was experiencing the prior crashes would test this I would be grateful.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal><br>Chris Richardson<o:p></o:p></p><p class=MsoNormal>WTI<o:p></o:p></p></div></body></html>