<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div><blockquote type="cite">Could you review and include if you agree, these patches from Debian ?<br><br>,----<br>| Description: Fix invalid cast from (short) integers to void pointers.<br>| <a href="http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/020_invalid_casts.patch">http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/020_invalid_casts.patch</a><br>`----<br></blockquote><div><br></div>OK, in the next version of our software, I'll change our code so that these compiler warning(?) messages will no longer occur.</div><div><br></div><div><br><blockquote type="cite">,----<br>| ip_mreq_source is defined in all glibc not just on kfreebsd.<br>| <a href="http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/021_ip_mreq_source.patch">http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/021_ip_mreq_source.patch</a><br>`----<br></blockquote><div><br></div>No. The problem here is your header files; not our code. (As far as I can tell, no other version of Linux - nor any other OS - has any problem with our existing code.)</div><div><br></div><div>It makes no sense for "struct ip_mreq_source" to be defined, but not "IP_ADD_SOURCE_MEMBERSHIP", because the whole purpose of "struct ip_mreq_source" is for setting "IP_ADD_SOURCE_MEMBERSHIP" (or "IP_DROP_SOURCE_MEMBERSHIP") in a 'setsockopt()' call.</div><div><br></div><div>Therefore, you need to find whichever of your header files defines "struct ip_mreq_source", and make sure that it also defines (or #includes a header file that defines) "IP_ADD_SOURCE_MEMBERSHIP" and "IP_DROP_SOURCE_MEMBERSHIP".</div><div><br></div><div><br></div><div><blockquote type="cite">,----<br>| Add a pkg-config file for the shared libraries.<br>| <a href="http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/add-pkgconfig-file.patch">http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/add-pkgconfig-file.patch</a><br>`----<br></blockquote><div><br></div>To date, noone other than 'Debian' has asked for a 'pkgconfig' file. Unless/until someone else also wants this for their (non-Debian) OS, I'll leave this as a Debian-specific patch, at least for now.</div><div><br></div><div><br></div><div><blockquote type="cite">,----<br>| Link shared libraries with g++ instead of gcc to fix build failure.<br>| <a href="http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/link-library-with-g%2B%2B.patch">http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/link-library-with-g%2B%2B.patch</a><br>`----<br></blockquote><div><br></div>Noone else has had any problems with the existing "config.linux" configuration file. Are you sure that *all* versions of Linux will define "$(CC)" and "$(CXX)", so that the "config.linux" file - if modified according to your patch - would work on *all* versions of Linux? (If not, then feel, if you wish, to propose a new "config-debian-linux" configuration that's specific to 'Debian'.)</div><br><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">Ross Finlayson<br>Live Networks, Inc.<br><a href="http://www.live555.com/">http://www.live555.com/</a></span></span>
</div>
<br></body></html>