<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 24, 2015, at 7:27 PM, Gilles Chanteperdrix <<a href="mailto:gilles.chanteperdrix@xenomai.org" class="">gilles.chanteperdrix@xenomai.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">On Mon, Feb 23, 2015 at 11:03:24AM +0100, Gilles Chanteperdrix wrote:<br class=""><blockquote type="cite" class=""> in the following<br class="">sequence of OnDemandServerMediaSubsession.cpp:<br class=""><br class=""><br class=""> if (streamState != NULL) {<br class=""> streamState->startPlaying(destinations,<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> rtcpRRHandler, rtcpRRHandlerClientData,<br class=""><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> serverRequestAlternativeByteHandler, serverRequestAlternativeByteHandlerClientData);<br class=""> RTPSink* rtpSink = streamState->rtpSink(); // alias<br class=""> if (rtpSink != NULL) {<br class=""> rtpSeqNum = rtpSink->currentSeqNo();<br class=""> rtpTimestamp = rtpSink->presetNextTimestamp();<br class=""> }<br class=""> }<br class=""></blockquote><br class="">The following patch avoids this issue:<br class=""></div></blockquote><div><br class=""></div>What ‘issue'?? Previously you said there was no ‘issue’ - i.e.:</div><div><br class=""></div><div><blockquote type="cite" class=""><blockquote type="cite" class="">Another source of bad RTP timestamps (but which does not seem to<br class="">cause any issue in live555) is when MultiFramedRTPSink starts<br class="">sending packets immediately with (a correct presentation time or<br class="">not) as a consequence of StreamState::startPlaying before<br class="">RTPSInk::presetNextTimestamp has been called</blockquote></blockquote><div><br class=""></div>I’m in no hurry to change any code that (in your words) “does not seem to cause any issue in live555”. But in any case, wouldn’t the ‘solution’ be to simply move the call to “startPlaying()” after the “if” statement that contains the call to “presetNextTimestamp()”?</div><div><br class=""></div><div>(I *do*, however, plan to fix the problem (that you noted) with old data being sent (after resuming from a “PAUSE”) because of it having been stored in ‘overflow data’ - once I’ve verified this.)</div><br class=""><br class=""><div apple-content-edited="true" class="">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">Ross Finlayson<br class="">Live Networks, Inc.<br class=""><a href="http://www.live555.com/" class="">http://www.live555.com/</a></span></span>
</div>
<br class=""></body></html>