<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:3.0cm 2.0cm 3.0cm 2.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DA" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">I am not sure if the purpose of MAX_NUM_EVENT_TRIGGERS is to be able to configure live555 for what is needed in a specific application, but with the latest changes to the event trigger code, I think it makes sense. If
for example only a few event triggers are used, we can avoid checking up to 32 entries in the fTriggersAwaitingHandling array in BasicTaskScheduler::SingleStep(…)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">However, if MAX_NUM_EVENT_TRIGGERS is set to something else than 32, the trigger events do not work as expected. I suggest the following changes:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">BasicUsageEnvironment0.hh line 76 (allow redefining MAX_NUM_EVENT_TRIGGERS)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">=============================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">#ifndef MAX_NUM_EVENT_TRIGGERS<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">#define MAX_NUM_EVENT_TRIGGERS 32<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">#endif<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">BasicTaskScheduler.cpp line 188<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">==========================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Replace<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">if (mask == 0) mask = 0x80000000;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">with<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">if (mask == 0) mask = (1 << (MAX_NUM_EVENT_TRIGGERS-1));<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">BasicTaskScheduler0.cpp line 98<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">==========================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Replace<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">if (mask == 0) mask = 0x80000000;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">with<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">if (mask == 0) mask = (1 << (MAX_NUM_EVENT_TRIGGERS-1));<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">BasicTaskScheduler0.cpp line 120 and 143<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">==================================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Replace<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">EventTriggerId mask = 0x80000000;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">with<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">EventTriggerId mask = (1 << (MAX_NUM_EVENT_TRIGGERS-1));<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:DA">Best Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:DA">Jan Rørgaard Hansen<o:p></o:p></span></b></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">Lead Software Developer</span><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:DA"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-AU" style="font-size:8.0pt;font-family:"Arial",sans-serif;mso-fareast-language:DA">Communication Solutions<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-AU" style="font-size:8.0pt;font-family:"Arial",sans-serif;mso-fareast-language:DA">Business Area Surveillance<i><o:p></o:p></i></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">Tel.: + 45 3638 3000<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-GB" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:EN-GB">Call me on:
<a href="skype:jan.r.hansen@dk.saabgroup.com?call"><span style="color:blue">Skype</span></a></span><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">E-mail:
</span><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;mso-fareast-language:DA"><a href="mailto:jan.r.hansen@dk.saabgroup.com"><span style="color:blue">jan.r.hansen@dk.saabgroup.com</span></a><span style="color:black"><o:p></o:p></span></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span style="mso-fareast-language:DA"><img border="0" width="113" height="36" style="width:1.177in;height:.375in" id="Picture_x0020_1" src="cid:image001.jpg@01D9BBE2.F718C920" alt="Saab_rgb_150px"></span><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">Saab Danmark A/S<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">Porten 6<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">DK – 6400 Sonderborg
<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span style="mso-fareast-language:DA"><a href="http://www.saabgroup.com/"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:blue">www.saabgroup.com</span></a></span><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><i><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">This e-mail is private and confidential between the sender and the addressee.
<o:p></o:p></span></i></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><i><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">In the event of misdirection, the recipient is prohibited from using, copying
or <o:p></o:p></span></i></p>
<p class="MsoNormal" style="line-height:12.0pt;text-autospace:none"><i><span lang="EN-US" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:black;mso-fareast-language:DA">disseminating it or information in it. Please notify the above if any misdirection.<o:p></o:p></span></i></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:DA"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>