[Live-devel] Probable bug

Ross Finlayson finlayson at live555.com
Fri Aug 31 05:34:20 PDT 2012


> This one is, I believe, an actual coding error, in the area of
> order-of-evaluation.
> 
> In the macro GET_ENCODED_VAL, in VorbisAudioRTPSink.cpp on line 129 (in
> the 2012.089.30 release), there's a possibly unintended evaluation of the
> phrase:
> 
>  "n = n*128 + byte&0x7F;"
> 
> I think, looking at the spacing around the statement, you intended:
> 
>  "n = (n*128) + (byte & 0x7f);"
> 
> What you're getting is:
> 
> "n = (n*128 + byte)&0x7f;"

Yes, thanks.  This bug is fixed in the latest release (2012.08.31) of the code.

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20120831/c1bc6eb4/attachment.html>


More information about the live-devel mailing list