[Live-devel] Unitialized memory in RTPReceptionStats

[Jeff Shanab]

Just an FYI.

    I have noticed that many items are not initialized on construction.
Mostly this shows up during incomplete usage by the programmer, me, but it is important to note that the checks for null that are in the code fail when in DEBUG on Windows.

GCC generally zero's things, Microsoft puts a sentinel value so it crashes and you can find those cases.







This message and any attachments contain confidential and proprietary information, and may contain privileged information, belonging to one or more affiliates of Windy City Wire Cable & Technology Products, LLC. No privilege is waived by this transmission. Unauthorized use, copying or disclosure of such information is prohibited and may be unlawful. If you receive this message in error, please delete it from your system, destroy any printouts or copies of it, and notify the sender immediately by e-mail or phone.

From: live-devel-bounces at ns.live555.com [mailto:live-devel-bounces at ns.live555.com] On Behalf Of Ross Finlayson
Sent: Friday, April 05, 2013 12:13 PM
To: LIVE555 Streaming Media - development & use
Subject: Re: [Live-devel] Unitialized memory in RTPReceptionStats

I know you don't like valgrind tool

I *do* like "valgrind".  The problem with it, however, is that it frequently reports 'errors' that aren't really errors.

Therefore, I generally don't pay attention when people send me "valgrind" reports, unless they can also note a specific problem in the code that is causing these reports to be generated.  But fortunately you have done this.



A way to fix this is to initialize

void RTPReceptionStats::init(u_int32_t SSRC) {

  fSSRC = SSRC;

  fTotNumPacketsReceived = 0;

  fTotBytesReceived_hi = fTotBytesReceived_lo = 0;

+  fBaseExtSeqNumReceived = 0;

+  fHighestExtSeqNumReceived = 0;

  fHaveSeenInitialSequenceNumber = False;

This will be fixed in the next release of the code (later today).  Thanks for the report.

Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20130405/f3252765/attachment-0001.html>