[Live-devel] Problem with fix in MPEG2TransportStreamFromESSource stops frame delivery

[Bruno Abreu]

Hello Ross,

In http://lists.live555.com/pipermail/live-devel/2013-January/016347.html I
described the following scenario:
"We have been running for some time a RTSPServer that acquires video from a live
source (with our own DeviceSource) from which we create 2 or 3 replicas: one for
multicast streaming and another to feed a FileSink for file storage. The third
replica is created on demand for unicast streaming." Our stream consists in a
H264 ES video which we encapsulate in MPEG2TS.

In recent versions we detected the following problem: when a unicast session is
created the whole pipeline, including replicas, stops sending video. We didn't
investigate this in much detail but, since it was working before, we compared
with older versions and found out that it was working until the live.2012.08.31
release.

So, we experimented to revert some changes in recent versions and one
specifically worked for us:
--- live.2013.01.15/liveMedia/MPEG2TransportStreamFromESSource.cpp  2012-12-19
17:53:50.000000000 +0000
+++ new/liveMedia/MPEG2TransportStreamFromESSource.cpp        2012-12-19
17:53:58.000000000 +0000

@@ -99,7 +99,7 @@ MPEG2TransportStreamFromESSource
 }
 
 MPEG2TransportStreamFromESSource::~MPEG2TransportStreamFromESSource() {
-  doStopGettingFrames();
   delete fInputSources;
 }

We think this change was introduced in the sequence of:
2012.09.11:
- Fixed a bug in "MPEG2TransportStreamFromESSource": Its destructor wasn't
stopping the delivery from upstream objects.
  (Thanks to Jing Li for reporting this.)

We don't know the impact of our change in the original fix.

Thank you,
Bruno Abreu


-- 
Living Data - Sistemas de Informação e Apoio à Decisão, Lda.

LxFactory - Rua Rodrigues de Faria, 103,
edifício I - 4º piso                  Phone:  +351 213622163
1300-501 LISBOA                       Fax:    +351 213622165
Portugal                              URL: www.livingdata.pt