[Live-devel] Possible error after code analysis

[Nikolai Vorontsov]

Hello Ross,
 
I've run code analysis tool against the Live555 and found two suspicious
places, which might be an error:
 
Live555 from 2014/02/19
 
H264or5VideoStreamFramer.cpp, line 696 (681):
unsigned num_negative_pics = 0;

unsigned num_positive_pics = 0;

>>> for (unsigned j = 0; j < num_negative_pics+num_positive_pics; ++j) {

so, these variables are not changed before the cycle and it's never run.
 
 
StreamParser.cpp, line 88 and 105:
 
return (unsigned)lastByte &~ ((~0)<<numBits);
if (numBits < 32) result &=~ ((~0)<<numBits);

You better use (~0u)<< expression, as signed shift left is UB.
 
Regards,
Nikolai 

________________________________

From: live-devel-bounces at ns.live555.com
[mailto:live-devel-bounces at ns.live555.com] On Behalf Of Ross Finlayson
Sent: Sunday, February 23, 2014 7:44 AM
To: LIVE555 Streaming Media - development & use
Subject: Re: [Live-devel] Error decoding stream



	I was wondering if the stream received with the
"testmp3receiver" had any ID3 tag in it, or was it only pure mp3 frames.


"testMP3Receiver" delivers data under the assumption that the incoming
stream was RTP-encoded MPEG-1 or 2 audio data (i.e., including MP3) that
was packetized according to RFC 2250.  If the server (i.e., transmitting
application) was "testMP3Streamer", then this data should be MPEG audio
only (no ID3 tag or anything else).  If, however, the server (i.e.,
transmitting application) was something else, then who knows...


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/ 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20140225/2749cd13/attachment.html>