[Live-devel] Debian patches

[Ross Finlayson]

> Could you review and include if you agree, these patches from Debian ?
> 
> ,----
> | Description: Fix invalid cast from (short) integers to void pointers.
> | http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/020_invalid_casts.patch
> `----

OK, in the next version of our software, I'll change our code so that these compiler warning(?) messages will no longer occur.


> ,----
> | ip_mreq_source is defined in all glibc not just on kfreebsd.
> | http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/021_ip_mreq_source.patch
> `----

No.  The problem here is your header files; not our code.  (As far as I can tell, no other version of Linux - nor any other OS - has any problem with our existing code.)

It makes no sense for "struct ip_mreq_source" to be defined, but not "IP_ADD_SOURCE_MEMBERSHIP", because the whole purpose of "struct ip_mreq_source" is for setting "IP_ADD_SOURCE_MEMBERSHIP" (or "IP_DROP_SOURCE_MEMBERSHIP") in a 'setsockopt()' call.

Therefore, you need to find whichever of your header files defines "struct ip_mreq_source", and make sure that it also defines (or #includes a header file that defines) "IP_ADD_SOURCE_MEMBERSHIP" and "IP_DROP_SOURCE_MEMBERSHIP".


> ,----
> | Add a pkg-config file for the shared libraries.
> | http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/add-pkgconfig-file.patch
> `----

To date, noone other than 'Debian' has asked for a 'pkgconfig' file.  Unless/until someone else also wants this for their (non-Debian) OS, I'll leave this as a Debian-specific patch, at least for now.


> ,----
> | Link shared libraries with g++ instead of gcc to fix build failure.
> | http://sources.debian.net/src/liblivemedia/2014.01.13-1/debian/patches/link-library-with-g%2B%2B.patch
> `----

Noone else has had any problems with the existing "config.linux" configuration file.  Are you sure that *all* versions of Linux will define "$(CC)" and "$(CXX)", so that the "config.linux" file - if modified according to your patch - would work on *all* versions of Linux?  (If not, then feel, if you wish, to propose a new "config-debian-linux" configuration that's specific to 'Debian'.)


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20140714/5673df35/attachment-0001.html>