[Live-devel] pause issue

[Ross Finlayson]

> On Feb 24, 2015, at 7:27 PM, Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org> wrote:
> 
> On Mon, Feb 23, 2015 at 11:03:24AM +0100, Gilles Chanteperdrix wrote:
>>  in the following
>> sequence of OnDemandServerMediaSubsession.cpp:
>> 
>> 
>>  if (streamState != NULL) {
>>    streamState->startPlaying(destinations,
>> 			      rtcpRRHandler, rtcpRRHandlerClientData,
>> 			      serverRequestAlternativeByteHandler, serverRequestAlternativeByteHandlerClientData);
>>    RTPSink* rtpSink = streamState->rtpSink(); // alias
>>    if (rtpSink != NULL) {
>>      rtpSeqNum = rtpSink->currentSeqNo();
>>      rtpTimestamp = rtpSink->presetNextTimestamp();
>>    }
>>  }
> 
> The following patch avoids this issue:

What ‘issue'??  Previously you said there was no ‘issue’ - i.e.:

>> Another source of bad RTP timestamps (but which does not seem to
>> cause any issue in live555) is when MultiFramedRTPSink starts
>> sending packets immediately with (a correct presentation time or
>> not) as a consequence of StreamState::startPlaying before
>> RTPSInk::presetNextTimestamp has been called

I’m in no hurry to change any code that (in your words) “does not seem to cause any issue in live555”.  But in any case, wouldn’t the ‘solution’ be to simply move the call to “startPlaying()” after the “if” statement that contains the call to “presetNextTimestamp()”?

(I *do*, however, plan to fix the problem (that you noted) with old data being sent (after resuming from a “PAUSE”) because of it having been stored in ‘overflow data’  - once I’ve verified this.)


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20150224/77cd00eb/attachment.html>