[Live-devel] [PATCH 2/2] MPEG, H264, H265: add option to preserve presentation time from source

[Stas Tsymbalov]

>> Thanks for advise, but passing presentation times separately from frames and around H264VideoStreamFramer seems far more complicated and clunky than this small change to framer, so I will stick with my solution.
> 
> OK, but remember this would complicate your obligations under the LGPL, because you would need to distribute your patch along with your product (so that your customers could - whenever they wished - replace the LIVE555 libraries with their own version).  Whereas if instead you use the existing, unmodified LIVE555 code with your own subclasses, then you wouldn’t need to distribute any of your own code.

We are aware of that, and since we are doing other changes to live555 code this does not complicate thing legal-wise.

> 	See http://live555.com/liveMedia/faq.html#copyright-and-license

We are going to distribute modified version of live555 in a form of dynamic library (as https://www.gnu.org/licenses/gpl-faq.html#LGPLStaticVsDynamic suggests, so users can replace LGPL-covered code with their modified versions) and provide modified source with modifications under compatible license according to LGPL 2.1 section 6d. To me this seems sufficient to comply with live555 license.

I didn't sent patches for that other changes because I think there is 0% chance of them being accepted:
  1. Support to build live555 into .dll on Windows (every public class and function have to be marked with __declspec(dllexport)/__declspec(dllimport)). When digging through live-devel archives I found out that similar patches were already rejected http://lists.live555.com/pipermail/live-devel/2004-July/000955.html http://lists.live555.com/pipermail/live-devel/2014-January/017951.html
  2. Changed gettimeofday() implementation that uses timeGetTime() instead of QueryPerformanceCounter(). This lowers gettimeofday() precision to milliseconds, generally a bad thing but we need it that way.

-- 
Stas Tsymbalov
TrueConf LLC
http://trueconf.com/