[Live-devel] Live555 DLL rather than static libs

[GRINDSTAFF Gene A]

Ross,

I am equally confused, but I believe it is because none of the other static variables are called/used in your base libraries.  If they were, then it would be an issue.  I have built numerous examples of your code, and this is the only issue I have found.  CMAKE can export the static member variable automatically, but there is no easy way to import the definition in Visual Studio.  It is just one of the many strange things about Visual Studio.

Thanks,
Gene

-----Original Message-----
From: live-devel <live-devel-bounces at ns.live555.com> On Behalf Of Ross Finlayson
Sent: Wednesday, October 17, 2018 9:38 AM
To: LIVE555 Streaming Media - development & use <live-devel at ns.live555.com>
Subject: Re: [Live-devel] Live555 DLL rather than static libs

> I agree completely.  I would never  want you to put Microsoftisms into your code.  Neither do I want to modify your code, and maintain and publish it forever.
> 
> Would you consider doing the following:
> 
> 1. Making the public class OutPacketBuffer member "maxSize" in mediaSink.hh private.

I’m confused by this, because there are several other examples of static member variables declared “public:” - e.g.:
	include/MPEG2TransportStreamFromESSource.hh:	static unsigned maxInputESFrameSize;
	include/MPEG2TransportStreamFromESSource.hh	static unsigned maxInputESFrameSize;
	include/RTSPClient.hh:							static unsigned responseBufferSize;
Why do these not also need to be be changed to make Microsoft’s broken compiler happy?

Also, are you aware of the function
	static void increaseMaxSizeTo(unsigned newMaxSize) which most people call to change the value of “maxSize” (because, in reality, most people want to just increase it)?


Ross Finlayson
Live Networks, Inc.
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.live555.com%2F&data=02%7C01%7Cgene.grindstaff%40hexagonsi.com%7C36e61db1a1244eaa25ed08d6343ec121%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C636753841493689380&sdata=CIgK0UQKr5pHzkoAHd2jgublXEQ5osO%2FThf%2BmFroAkk%3D&reserved=0


_______________________________________________
live-devel mailing list
live-devel at lists.live555.com
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.live555.com%2Fmailman%2Flistinfo%2Flive-devel&data=02%7C01%7Cgene.grindstaff%40hexagonsi.com%7C36e61db1a1244eaa25ed08d6343ec121%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C636753841493699388&sdata=8wKsaJz326JsbMxwUGlN5aW5GFWMrGDWsesxSARNEmU%3D&reserved=0