[Live-devel] Location of cast used to interface to OpenSSL

[Ross Finlayson]

OK, I have just installed a new version (2019.12.13) of the “LIVE555 Streaming Media” code.


> - The new flag -DNO_OPENSSL=1 should directly be set in the COMPILE_OPTS variable, and not in the C_FLAGS because it is not taken in account at the compilation (and visual fails to compile the TLSState.hh file)

I presume this is referring to the “win32config” file (that’s used to generate Makefiles for WIndows).  I have now moved "-DNO_OPENSSL=1” to “COMPILE_OPTS”.


> - The cast problem from u_int8_t* to char* that Jeff has risen, leads to a compilation failure (at least of visual studio 2010 and 2012). So at least an explicit cast is needed I think.

OK, in the new version of the code, I have changed the signature of the “data” parameter in the “RTSPClient::write()” function (and the “TLSState::write()” function) to “const char*”.


> - At a first glance, only the change of the function RTSPClient::parseRTSPURL by removing its static status (due to the use of the useTLS() I guess?) impacts our integration.

I don’t understand what this means.  Everybody should be upgrading to the new version of our code by doing a “make clean”; completely replacing the LIVE555 source code; copying your own custom “config.” file (if necessary); re-generating Makefiles; and then running “make”.  Nobody should be relying on having their own modifications to the LIVE555 source code.


> - An useful evolution should be to afford the possibility to specify the path of the openSSL for libdir and include dir instead of the hardcoded path  /usr/local/include?

Maybe - but in any case, that requires changing the appropriate “config.” file (or using your own “config.” file) - which anyone is free to do in any case.


> - Minor points are the presence of new files (VIDEO-0x0001-0x00e0.h264, bad.ts, bad.txt) that overweight the tar.gz

Oops.  Those files got left in the “liveMedia” directory by mistake.  They’re gone now.


Ross Finlayson
Live Networks, Inc.
http://www.live555.com/