[Live-devel] live-devel Digest, Vol 162, Issue 9

[Gerald Hansink]

in RTSPClient destructor the same "socket num" (fInputSocketNum) must be
used when clearing "server request alternative byte handler"
as when setting the handler, but this socket num fInputSocketNum is
"cleared" in resetTCPSockets and in grabSocket,
so if after setting the "server request alternative byte handler"
resetTCPSockets or grabSocket is called and then the RTSPClient is deleted
the handler is not cleared
which then contains pointer to the deleted RTSPClient

best regards
gerald



---------- Forwarded message ----------
> From: <live-devel-request at ns.live555.com>
> Date: Wed, May 10, 2017 at 9:00 PM
> Subject: live-devel Digest, Vol 162, Issue 9
> To: live-devel at ns.live555.com
>
>
> Send live-devel mailing list submissions to
>         live-devel at lists.live555.com
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         http://lists.live555.com/mailman/listinfo/live-devel
> or, via email, send a message with subject or body 'help' to
>         live-devel-request at lists.live555.com
>
> You can reach the person managing the list at
>         live-devel-owner at lists.live555.com
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of live-devel digest..."
>
>
> Today's Topics:
>
>    1. Re: segfault RtspClient (Ross Finlayson)
>    2. Re: segfault RtspClient (Ross Finlayson)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Tue, 9 May 2017 12:04:48 -0700
> From: Ross Finlayson <finlayson at live555.com>
> To: LIVE555 Streaming Media - development & use
>         <live-devel at ns.live555.com>
> Subject: Re: [Live-devel] segfault RtspClient
> Message-ID: <0EAA9CFB-4D90-4550-A3E0-48BFCF2C8C67 at live555.com>
> Content-Type: text/plain; charset=utf-8
>
> > in previous version in RtspClient::resetTCPSockets the "alternative byte
> handler" is cleared using the "input socket num" before setting it to -1.
> >
> >          RTPInterface::clearServerRequestAlternativeByteHandler(envir(),
> fInputSocketNum); // in case we were receiving RTP-over-TCP
> >
> > i think this line should be added again?
>
> I?m puzzled.  That line *is* in the ?RTSPClient? destructor (see
> ?RtspClient.cpp?, line 400), and has been there for several years, I think.
>
> Are you sure you really have the latest version of the code?  See
> http://live555.com/liveMedia/faq.html#latest-version
>
>
> Ross Finlayson
> Live Networks, Inc.
> http://www.live555.com/
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Tue, 9 May 2017 12:25:21 -0700
> From: Ross Finlayson <finlayson at live555.com>
> To: LIVE555 Streaming Media - development & use
>         <live-devel at ns.live555.com>
> Subject: Re: [Live-devel] segfault RtspClient
> Message-ID: <A080B9B8-6609-4ACA-83A4-DB99106F8B2F at live555.com>
> Content-Type: text/plain; charset=utf-8
>
> > in previous version in RtspClient::resetTCPSockets the "alternative byte
> handler" is cleared using the "input socket num" before setting it to -1.
> >
> >         RTPInterface::clearServerRequestAlternativeByteHandler(envir(),
> fInputSocketNum); // in case we were receiving RTP-over-TCP
> >
> > i think this line should be added again?
>
> OK, I think I understand now what you?re asking.  The line you?re talking
> about is currently in the ?RTSPClient? destructor, but *not* in the
> ?resetTCPSockets()? function (which is called more often).
>
> I?ll take a closer look at the code, to see whether it should be put
> (back?) in ?resetTCPSockets()? instead.  Stay tuned?
>
>
> Ross Finlayson
> Live Networks, Inc.
> http://www.live555.com/
>
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> live-devel mailing list
> live-devel at lists.live555.com
> http://lists.live555.com/mailman/listinfo/live-devel
>
>
> ------------------------------
>
> End of live-devel Digest, Vol 162, Issue 9
> ******************************************
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.live555.com/pipermail/live-devel/attachments/20170524/064fce5e/attachment.html>